- Issue created by @ytsurk
- First commit to issue fork.
- @elber opened merge request.
- 🇧🇷Brazil elber Brazil
hi I removed some dependencies but I don't know if I understand the issue, please revise.
- Status changed to Needs review
over 1 year ago 2:59pm 27 February 2023 - First commit to issue fork.
- 🇪🇪Estonia rang501 Viljandi
As I understand, removing dependencies from composer.json was the goal of this task and the MR seems to do that, so I will merge it to 2.1.x branch.
- Status changed to Fixed
over 1 year ago 8:56pm 28 February 2023 - Status changed to Needs work
over 1 year ago 11:58pm 8 March 2023 - 🇨🇭Switzerland ytsurk Switzerland
Alright - we do not want this.
composer is no longer getting our dependencies like that.
This needs to be reverted!
- 🇪🇪Estonia rang501 Viljandi
Latest change is causing issues - composer doesn't like custom fork of entity_embed module now. Do we need version restrictions at all?
- 🇨🇭Switzerland ytsurk Switzerland
I would not allow a -dev-mr-version in our composer.json
You should add entity_embed via mr-repo (in composer.json of your project):
"repositories": {
"entity_embed": {
"type": "git",
"url": "git@git.drupal.org:issue/entity_embed-3272732.git"
},and then
"drupal/entity_embed": "dev-3272732-drupal-10-",
- 🇪🇪Estonia rang501 Viljandi
It is like that, but composer update throws an error:
drupal/media_directories dev-2.1.x requires drupal/entity_embed >=1.3 -> found drupal/entity_embed[dev-8.x-1.x] but it conflicts with your root composer.json require (dev-3272732-drupal-10-).But I was able to bypass it with inline alias:
"drupal/entity_embed": "dev-3272732-drupal-10- as 1.3"So I guess, its fine then.
- 🇨🇭Switzerland ytsurk Switzerland
Alright - Great that it works for you like this.
- 🇩🇪Germany rgpublic Düsseldorf 🇩🇪 🇪🇺
NB: This bug unfortunately causes a dependency on entity browser even if media_directories_ui isn't even enabled. :-(