- Issue created by @jeffreysmattson
- Merge request !17Issue #3344319: Need to Create Views Relationship β (Merged) created by jeffreysmattson
- Status changed to Needs review
almost 2 years ago 5:43pm 24 February 2023 - Status changed to Needs work
over 1 year ago 8:00pm 15 April 2023 - πΊπΈUnited States fathershawn New York
Please rebase your MR to the 1.1.x branch
- πΊπΈUnited States Fool2
I know it needs rebasing so I won't change the status but I want to add my +1 as tested the diff as a patch and it works great. I was able, for instance, to create a view display where we pass UUID as an argument to match the relationship and plop it in the node edit form to show users quickly if a node has subscriptions:
views_embed_view('syndicated_content', 'embed_1', $entity->uuid->value);
- last update
10 months ago 6 pass, 4 fail - πΊπΈUnited States jeffreysmattson
I updated the MR to apply to the 1.1.x branch. It looks like rebasing isn't necessary. Am I wrong?
- πΊπΈUnited States jeffreysmattson
I have tried to figure out how to rebase this onto 1.1.x but still am unable to. I cannot fetch the 1.1.x branch because it is not available to me for some reason.
MacBook-Pro-100:entity_share_websub-3344319 f002bw2$ git fetch entity_share_websub-3344319 From git.drupal.org:issue/entity_share_websub-3344319 * [new branch] 1.0.x -> entity_share_websub-3344319/1.0.x * [new branch] 2.x -> entity_share_websub-3344319/2.x * [new branch] 3344319-need-to-create -> entity_share_websub-3344319/3344319-need-to-create * [new branch] issue-3287314 -> entity_share_websub-3344319/issue-3287314
These are all that are available. I am able to rebase onto 2.x, but that doesn't seem to help here. I am not sure what I am doing wrong.
In the gitlab page here: https://git.drupalcode.org/issue/entity_share_websub-3344319/-/tree/3344...
In the "Select Git revision" dropdown 1.1.x is not listed.What am I doing wrong?
- πΊπΈUnited States fathershawn New York
I left a note about how to connect to the main repo and pull the main branch in another issue https://www.drupal.org/project/entity_share_websub/issues/3321672#commen... β¨ Need Custom Hub EndPoint URL Needs work
- last update
10 months ago 4 pass, 6 fail - πΊπΈUnited States jeffreysmattson
This has been re-based and tests are passing.
- Status changed to Needs review
4 days ago 4:13pm 18 December 2024 - πΊπΈUnited States fathershawn New York
There is a minor code quality issue in the test results
FILE: ...-3344319/modules/entity_share_websub_hub/entity_share_websub_hub.views.inc -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 40 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Arrays.DisallowLongArraySyntax.Found) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------
-
fathershawn β
committed 65cdc024 on 1.1.x authored by
jeffreysmattson β
Issue #3344319 by jeffreysmattson: Need to Create Views Relationship
-
fathershawn β
committed 65cdc024 on 1.1.x authored by
jeffreysmattson β