- Status changed to Needs review
over 1 year ago 6:19pm 15 March 2023 - Status changed to Needs work
over 1 year ago 7:56pm 15 April 2023 - πΊπΈUnited States fathershawn New York
This seems like a worthwhile feature, but to be contributed it would need to be fully implemented. Also, we should now work against the 1.1.x branch. A simpler solution is to alter the module to use a more unique path, something like
/entity_share/hub/subscribe
- last update
11 months ago 4 pass, 6 fail - πΊπΈUnited States jeffreysmattson
I apologize for all the mess here. I am trying to figure out how to fork it from the 1.1.x branch but gitlab does seem to have that branch available for me. Do I have to start a completely new issue to do that?
- πΊπΈUnited States fathershawn New York
No, but if you are changing branches you can push the 1.1.x branch into the created issue fork, or rebase your work onto it locally and push to the issue fork
- πΊπΈUnited States jeffreysmattson
I would change branches but for whatever reason the branch 1.1.x is not found in this fork so I can't change to it. I would really like to figure out how to do this successfully but hit road block after road block. Should I clone the original repo `entity_share_websub`, I can see the 1.1.x branch there, but my issue branch is not. The two things are not in the same place.
- πΊπΈUnited States fathershawn New York
You don't need to clone the main repo, just add it as another remote where you are working on this code:
git remote add -f -t '1.1.x' main-repo git@git.drupal.org:project/entity_share_websub.git
You can then checkout 1.1 locally
- last update
9 months ago 4 pass, 6 fail - πΊπΈUnited States jeffreysmattson
I think I did it. Thank you for that git command that made all the difference. Looks like the unit tests are failing. Is that from my code or is that a problem in the branch itself? Thank you for your help on this one.
- πΊπΈUnited States fathershawn New York
Well, the old testing service is deprecating. I'll add the new service to the 1.1 branch and let you know
- πΊπΈUnited States fathershawn New York
Ha! I did add the new service last November. At which point, 1.1.x was passing:
https://git.drupalcode.org/project/entity_share_websub/-/pipelinesBut your MR 20 is not passing in the new tests: https://git.drupalcode.org/project/entity_share_websub/-/merge_requests/20
- πΊπΈUnited States fathershawn New York
Looking at the results, I find this error more than once:
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "Drupal\jsonapi\Controller\TemporaryJsonapiFileFieldUploader" has a dependency on a non-existent service "file.validator". Did you mean one of these: "form_validator", "path.validator", "email.validator"?
And I just re-ran 1.1.x against changes in core since last November, and it failed. I'll post when it is passing again
- πΊπΈUnited States fathershawn New York
Test failures are fixed in the main 1.1.x branch. Please re-base onto the upstream branch and refresh your feature branch.
- πΊπΈUnited States jeffreysmattson
I have re-based and test are passing. Success!