Webform handler postSave() method is triggered before completing the database transaction

I hesitate to change how a handler's postSave() method works. It will most likely cause issues for other people.

Would it be an idea, to document somewhere that the actual committing(saving) actually happens after the postSave, so any code that breaks the flow will abandon the save? Maybe it's an edge case, but at least having it down in writing might alert people.

I am always open to documentation improvements. Would you be able to create a PR with a suggestion?

Makes sense. I can do it for us

Implemented: https://git.drupalcode.org/project/webform/-/merge_requests/311

Implemented: https://git.drupalcode.org/project/webform/-/merge_requests/311

Nice! I just thought of this part:

breaks the PHP execution it may cause a fail in the final save.

I would change it up to this:

breaks the PHP execution it may prevent the sql transaction from committing.

Or do you guys think that's a tad to technical for the documentation? In my opinion it shed's a light on why it wouldn't be saved.

@jrockowitz

I hesitate to change how a handler's postSave() method works. It will most likely cause issues for other people.

Just checking, because your answer seems to contradict what actually happened:
Our code has not changed for years, but suddenly broke after updating Webform and/or Drupal core.

If you know for sure that this change in handling the postSave() is being caused by a change in Drupal core, than I think it's fine to simply document it.
However if not, I think it still should be investigated as a bug, because contrary to what you say this possible bug most likely cause issues for other people; fixing it will fix it :)

Could you elaborate on your vision about this? Don't you think that a postSave() should be an actual post-save, and not a before-commit-save?

breaks the PHP execution it may prevent the sql transaction from committing.

Totally makes sense. Agreed

MR updated with that suggestion at #10: https://git.drupalcode.org/project/webform/-/merge_requests/311

This causes a problem in the use case i've got.

I'm using the webform rest module to trigger a get submission on PostSave but it always get the previous data as it hasn't been committed to the database yet.

Automatically closed - issue fixed for 2 weeks with no activity.