- Issue created by @renatog
- @renatog opened merge request.
- Status changed to Needs review
almost 2 years ago 11:56pm 21 February 2023 - 🇧🇷Brazil renatog Campinas
MR open with the fix: https://git.drupalcode.org/project/weight/-/merge_requests/9
- heddn Nicaragua
Could we get a test showing the failure and a fix? This is a new module to me, and I'm not aware of all the edge cases where text field input might actually be desired.
- 🇧🇷Brazil renatog Campinas
@heddn Just to confirm as a double-check, do you mean, automated tests with PHPUnit that's right?
If yes, I think really makes sense
I was thinking to open this in a separated issue, with that we can fix this issue and work in the PHPUnit separated, what do you think?
- Status changed to Needs work
almost 2 years ago 2:56pm 22 February 2023 - heddn Nicaragua
Adding the test w/ the fix is the better approach as it shows what is at issue and proves we fix things. I'm mainly proposing this since as a new maintainer, I was to be overly cautious about breaking existing sites. And adding test coverage helps here.
- last update
about 1 year ago 1 pass