- Issue created by @milos.kroulik
- @miloskroulik opened merge request.
- Status changed to Needs review
almost 2 years ago 8:29pm 21 February 2023
The GoogleTagResponseSubscriber::addTag method processes every response. This is problematic, because binary response content needs to be zero in \Symfony\Component\HttpFoundation\BinaryFileResponse::setContent, otherwise LogicException: The content cannot be set on a BinaryFileResponse instance. is thrown.
if ($response instanceof BinaryFileResponse) {
return;
}
needs to be added near the beginning of GoogleTagResponseSubscriber::addTag method.
Needs review
1.0
Code