Questions about releases and compatibility

This module is meeting a difficult challenge. swiftmailer became unsupported when this project had barely begun, so people started using the alpha version of this module on live sites. Also it's mostly just me developing it, in my spare time - and it's a pretty ambitious project for that.

It turns out the BC plugin, CommerceEmailBuilder, needs to be updated

I guess you are referring to #3276029: Improve email creation → which was part of 1.0.0-alpha8. Yes there was a BC break in an alpha release, but well that's the point of alpha releases😃.

This module is very confusing in that it's never even had a full release, just a bunch of alphas, betas, and now an RC

But this is the normal sequence, yes😃😃?? Stable version is coming soon.

with BC breaks randomly sprinkled throughout

During alpha??? I've been fairly careful about BC after that. Not as careful as Drupal Core would be, sure, but reasonably careful I feel.

The first full release of a module ought to be 1.0.0

Says who😃😃? There was a reasonable justification for a minor version change before we reached stable.

What's the process for this? Both from a code standpoint and a release standpoint, how are we supposed to update it and stay on top of any future backwards compatibility breaks?

After the first beta release, BC breaks would require a major version change, as normal in the Drupal world.

I wonder, do you actually need CommerceEmailBuilder?

With the newer releases of this module (I was adding a lot of improvements as well as annoying you by breaking BC😃), the behaviour matches swiftmailer quite well without a specific email builder, using LegacyEmailBuilder. Possibly your CommerceEmailBuilder has minimal effect.

There is ✨ Full integration with commerce module Fixed which plans a full integration. I'd be interested to discuss that with you if you'd like to.

I'm not really sure what we need, to be honest ... I just knew the existing state of the module was such that installing it alongside Commerce would break things. I'm more than happy to help maintain Commerce specific plugins if I know what to look out for - in this case, I just couldn't tell from my initial look at the code what needed to be updated.

I'm more than happy to help maintain Commerce specific plugins

Great.

Please can you point me to your CommerceEmailBuilder? I can't find it in the commerce core project.

@AdamPS fwiw, in the above, I was talking about Commerce specific code in your project. The class in question is in this module, not in Commerce Core. Like I said, still happy for us to contribute to its maintenance, would just need guidance on what you even expect for that feature of this module.

@rszrama Great. First step is if someone on your team could test/review the current code. I sent you a message via your contact form.

Automatically closed - issue fixed for 2 weeks with no activity.

We've tested 1.2.1 and it works great! Kickstart 3.x has been updated to that now. 😊