- 🇬🇧United Kingdom adamps
The problem with other keys like 'shipment_confirmation' should now be fixed.
- last update
over 1 year ago 4 pass, 2 fail The last submitted patch, 38: symfony_mailer.commerce.3271421-38.patch, failed testing. View results →
- last update
over 1 year ago 5 pass -
AdamPS →
committed 02c1a536 on 1.x
Issue #3271421 by AdamPS, tarasiadis, 4kant: Full integration with...
-
AdamPS →
committed 02c1a536 on 1.x
- Status changed to Fixed
over 1 year ago 1:10pm 21 April 2023 -
AdamPS →
committed 9198f976 on 1.x
Issue #3271421 by AdamPS: Full integration with commerce module (fix...
-
AdamPS →
committed 9198f976 on 1.x
- Issue was unassigned.
-
AdamPS →
committed 775e6bb6 on 1.x
Issue #3271421 by AdamPS: Full integration with commerce module (...
-
AdamPS →
committed 775e6bb6 on 1.x
- 🇬🇧United Kingdom adamps
Sorry this issue was eventually fixed in 3 commits
- Status changed to Needs review
over 1 year ago 5:36pm 22 April 2023 - last update
over 1 year ago 5 pass - 🇬🇧United Kingdom adamps
New patch fixes some missing config defaults
-
AdamPS →
committed 8f8f6455 on 1.x
Issue #3271421 by AdamPS: Full integration with commerce module
-
AdamPS →
committed 8f8f6455 on 1.x
- Status changed to Fixed
over 1 year ago 11:48am 23 April 2023 - 🇬🇧United Kingdom adamps
Sorry this issue was eventually fixed in 4 commits
- 🇩🇪Germany geek-merlin Freiburg, Germany
This is awesome progress! I hope i can soon-ish leverage and test this in a project.
There are some comments in CommerceOrderEmailBuilder code that Commerce Core may need some adjustments, too.
Does this mean that this integration conflicts with the existing integration?
Does this need additional followups for Commerce Core, or are some on the way?+ * @todo Notes for adopting Symfony Mailer into commerce. It should be possible + * to remove the MailHandler service and classes such as OrderReceiptMail. The + * commerce_order_receipt template could be retired, switching instead to use + * email__commerce_order_type__receipt or by editing Mailer Policy for + * commerce_order_type.
- 🇬🇧United Kingdom adamps
@geek-merlin
This issue adds integration of Commerce and Symfony Mailer by adding code to Symfony Mailer. It's complete and working (as far as I know😃) without any further changes to Commerce.Those comments relate to a theoretical future date when Commerce might decide to adopt Symfony Mailer by changing code in Commerce (after which the code added in this issue could be removed).
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 6:40pm 19 May 2023 - 🇨🇦Canada jmee Canada
Just applied the patch and find the changes for "Commerce order" to work pretty much as expected, awesome! Thanks for this patch!
I'm having issues trying to use the new "Commerce order" policy type, it seems that the email is using the commerce_order.html.twig template, which is the default entity display for the order entity.
My use case: I have a functioning template in my theme called commerce-order-receipt.html.twig and I was hoping to use a mailer policy to customize the BCC and Subject depending on the order type, but to continue using the Body from my custom template (ie. not add a body element to the policy).
In the theme debug:
THEME HOOK: 'commerce_order' FILE NAME SUGGESTIONS: * commerce-order--5--email.html.twig * commerce-order--5.html.twig * commerce-order--download--email.html.twig * commerce-order--download.html.twig * commerce-order--email.html.twig x commerce-order.html.twig
If I customize any of these templates, I'll be changing how the site displays orders. I also don't have access to the same variables as the commerce-order-receipt template.
This template is called by email.html.twig:
THEME HOOK: 'email' FILE NAME SUGGESTIONS: * email--commerce-order-type--resend-receipt--download.html.twig * email--commerce-order-type--resend-receipt.html.twig * email--commerce-order-type.html.twig x email.html.twig
Again, not really a feasible option.
It seems like the intended use case for this patch is new users of Commerce, so existing users of commerce and symfony_mailer may have a hard time taking advantage of the features. In order to use the Commerce order policy type, the body content *must* be added as a policy element and it is not possible to use a twig template -- is that correct ?
If so, I think there's a good argument to change this behaviour and instead fall back to the default commerce-order-receipt template
- 🇳🇱Netherlands Martijn de Wit 🇳🇱 The Netherlands
@jmee if you experiencing any new problems. Please open a new ticket as follow up.