MigrateBatchExecutable "progressMessage" incorrect visibility

Created on 21 February 2023, over 2 years ago

Problem/Motivation

In https://www.drupal.org/project/migrate_tools/issues/3278850 🐛 MigrateBatchExecutable doesn't need additional progress messages Fixed , a new progressMessage method was added to MigrateBatchExecutable.php.

However, it was added with the protected visibility which causes issues as MigrateExecutable has it as public visibility. This causes a PHP fatal error.

Steps to reproduce

Install Migrate Tools 6.x
Configure a migration to use MigrateBatchExecutable
Notice a fatal error is thrown with the progressMessage method being noted

Proposed resolution

Make MigrateExecutable's progressMessage public visibility.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

6.0

Component

Code

Created by

🇺🇸United States Nuuou Lincoln, NE

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Nuuou
Comment over 2 years ago →
🇳🇿New Zealand xurizaemon Ōtepoti, Aotearoa 🏝
Status changed to Needs review over 2 years ago3:22pm 20 April 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 2 years ago
36 pass
Comment over 2 years ago →
🇧🇪Belgium gilles_webstanz
Hello,

We have noticed that the signature of the function is different.

Here is a patch to correct this.

Have a nice day.
Status changed to Postponed: needs info 3 months ago7:13pm 4 July 2025
Comment 3 months ago →
heddn Nicaragua
I only ever see it as protected. Where do we see it public? It was added protected way back in 2015.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024