Fix the issues reported by phpcs

Created on 21 February 2023, over 1 year ago
Updated 22 March 2023, over 1 year ago

Problem/Motivation

FILE: ...al\modules\affected_by_promotion\src\AffectedEntitiesManager.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
10 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...cted_by_promotion\src\SupportsAffectedEntitiesQueryInterface.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
7 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...ules\affected_by_promotion\tests\src\Unit\DummyPromotionBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 13 WARNINGS AFFECTING 14 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
12 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
19 | WARNING | [x] 'TODO: Implement getConfiguration() method.'
| | should match the format '@todo Fix problem X
| | here.'
26 | WARNING | [x] 'TODO: Implement setConfiguration() method.'
| | should match the format '@todo Fix problem X
| | here.'
33 | WARNING | [x] 'TODO: Implement defaultConfiguration() method.'
| | should match the format '@todo Fix problem X
| | here.'
40 | WARNING | [x] 'TODO: Implement calculateDependencies()
| | method.' should match the format '@todo Fix
| | problem X here.'
50 | WARNING | [x] 'TODO: Implement buildConfigurationForm()
| | method.' should match the format '@todo Fix
| | problem X here.'
60 | WARNING | [x] 'TODO: Implement validateConfigurationForm()
| | method.' should match the format '@todo Fix
| | problem X here.'
70 | WARNING | [x] 'TODO: Implement submitConfigurationForm()
| | method.' should match the format '@todo Fix
| | problem X here.'
77 | WARNING | [x] 'TODO: Implement getPluginId() method.' should
| | match the format '@todo Fix problem X here.'
84 | WARNING | [x] 'TODO: Implement getPluginDefinition() method.'
| | should match the format '@todo Fix problem X
| | here.'
91 | WARNING | [x] 'TODO: Implement getEntityTypeId() method.'
| | should match the format '@todo Fix problem X
| | here.'
101 | WARNING | [x] 'TODO: Implement apply() method.' should match
| | the format '@todo Fix problem X here.'
108 | WARNING | [x] 'TODO: Implement clear() method.' should match
| | the format '@todo Fix problem X here.'
----------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...fected_by_promotion\tests\src\Unit\DummyPromotionNoInterface.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
7 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...cted_by_promotion\tests\src\Unit\DummyPromotionWithInterface.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n"
| | but found "\r\n"
9 | WARNING | [ ] The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...affected_by_promotion\tests\src\Unit\GetAffectedEntitiesTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but
| | found "\r\n"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Steps to reproduce

Run the following command :
phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /10.1.x/drupal/modules/contrib/affected_by_promotion

Proposed resolution

Fix all the PHP coding standard issues.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India Charchil Khandelwal

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024