- Issue created by @BenStallings
- πΊπΈUnited States BenStallings
(Incidentally, the patch above also silences a PHP warning that occurs if the value type isn't set. Extra credit)
- Status changed to Needs review
almost 2 years ago 10:02pm 20 February 2023 - π¦πΉAustria drunken monkey Vienna, Austria
Thanks a lot for posting this issue and providing a patch!
I could reproduce the problem, and indeed it seems clear that this deviates from the expected behavior. Your fix also seems sensible.What was still missing, though, was a regression test which I have added in the attached patch. I also had a tiny nitpick about code style.
Please test/review and I can commit this. The last submitted patch, 6: 3343250-6--date_filter_max_inclusive--tests_only.patch, failed testing. View results β
- πΊπΈUnited States BenStallings
Thanks for the code style fix. I'm afraid I don't understand how the regression test works, so I'm not qualified to review it. I hope someone else will review it for you.
-
drunken monkey β
committed 1422e599 on 8.x-1.x authored by
BenStallings β
Issue #3343250 by BenStallings, drunken monkey: Fixed the Views date "...
-
drunken monkey β
committed 1422e599 on 8.x-1.x authored by
BenStallings β
- Status changed to Fixed
almost 2 years ago 8:58am 19 March 2023 - π¦πΉAustria drunken monkey Vienna, Austria
Well, I guess the regression test not being reviewed is not such a big deal, as long as it works as expected (as proven by the test bot).
So, committed. Thanks a lot again! Automatically closed - issue fixed for 2 weeks with no activity.