If a filter wraps the drupal-media tag in a paragraph, the edit button breaks

Created on 17 February 2023, almost 2 years ago

Updated 18 April 2024, 8 months ago

There is an open core issue 🐛 If a filter wraps the drupal-media tag in a paragraph, the edit button breaks Needs work for a JS error when embedding media, which prevents the "Edit media" button from appearing in the editor. I'm experiencing this issue when "Limit allowed HTML tags and correct faulty HTML" and "Convert line breaks into HTML" are disabled. Applying the changes from https://www.drupal.org/project/drupal/issues/3097338#comment-13384875 🐛 If a filter wraps the drupal-media tag in a paragraph, the edit button breaks Needs work fixes the issue for me.

Disable Limit allowed HTML tags, Convert line breaks into HTML for a text format using CKEditor.
Embed media into a textarea using the text format.
Observe the missing edit button, check the console.

MR, test, merge :)

N/A

N/A

N/A

🐛 Bug report

Status

RTBC

Version

1.0

Component

Code

Created by

🇺🇸United States scottsawyer Atlanta

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @scottsawyer
@scottsawyer opened merge request.
Status changed to Needs review almost 2 years ago5:46am 18 February 2023
Comment almost 2 years ago →
🇺🇸United States scottsawyer Atlanta
Update status
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
54 pass
Comment over 1 year ago →
🇺🇸United States afayland
Re-rolled the patch from https://www.drupal.org/project/drupal/issues/3097338#comment-13385746 🐛 If a filter wraps the drupal-media tag in a paragraph, the edit button breaks Needs work to move the updates within the ckeditor module.
Status changed to RTBC 8 months ago6:54pm 18 April 2024
Comment 8 months ago →
🇺🇸United States firewaller
Patch #4 works for us

Production build 0.71.5 2024