- Issue created by @achap
- @achap opened merge request.
- Status changed to Needs review
over 1 year ago 4:56am 17 February 2023 - Status changed to Needs work
over 1 year ago 11:10pm 21 February 2023 - Status changed to Needs review
over 1 year ago 11:57pm 21 February 2023 - achap π¦πΊ
I think I have replicated the issue you were talking about with unrelated changes in the diff. It seems to be only when you add .patch to the end. Gitlab looks to be using a cached diff that no longer applies, though the diff itself (without .patch) is fine.
- Status changed to Needs work
over 1 year ago 2:09am 22 February 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Can we add some test coverage for this?
- Status changed to Needs review
over 1 year ago 7:08am 22 February 2023 - achap π¦πΊ
Not sure if you agree with the testing approach or not?
I initially tried to mock the dependencies of
BackendClient
for a unit test but there are a lot and ran into issues withAnalyserManager
being a final class and mocking that not being allowed, and generally having too much mocking of dependencies. Eventually, I just created a test subscriber to assert that the event was dispatched correctly. - Status changed to Needs work
over 1 year ago 1:06am 23 February 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
NW for the feedback
- Status changed to Needs review
over 1 year ago 1:37am 24 February 2023 - Status changed to Needs work
over 1 year ago 3:44am 24 February 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Needs a rebase on 2.x
- Status changed to Fixed
over 1 year ago 11:29pm 27 February 2023 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Committed to 2.x. Thanks!
- achap π¦πΊ
Thanks! I just tried to pull the latest 2.x but the code from the MR issue isn't in there
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Something weird happened with the merge button here. Looks like there was a conflict to I merged with 2.x and pushed.
-
kim.pepper β
committed 098d5c00 on 2.x authored by
achap β
Issue #3342539 by achap, kim.pepper: Dispatch event when index is...
-
kim.pepper β
committed 098d5c00 on 2.x authored by
achap β
Automatically closed - issue fixed for 2 weeks with no activity.