- Issue created by @danflanagan8
- Status changed to Needs review
over 2 years ago 3:43pm 16 February 2023 - 🇺🇸United States danflanagan8 St. Louis, US
Here's a hopefully inoffensive patch.
- 🇦🇺Australia dpi Perth, Australia
Thanks for the patch, just what I needed.
- First commit to issue fork.
- Merge request !73Issue #3342409: redirect_form_node_form_alter calls getInternalPath on potentially unrouted url → (Open) created by mahtab_alam
- last update
almost 2 years ago 63 pass - Status changed to RTBC
8 months ago 3:08pm 9 February 2025 - 🇺🇸United States mlncn Minneapolis, MN, USA
Working, and the code is a straightforward minimal validity check.
- Status changed to Needs work
about 1 month ago 5:03pm 29 August 2025 - 🇺🇸United States mlncn Minneapolis, MN, USA
Frustratingly, instead of being committed, this now needs a re-roll :-/
- Merge request !164[#3342409] feat: redirect_form_node_form_alter calls getInternalPath on potentially unrouted url → (Open) created by mlncn
- 🇦🇺Australia dpi Perth, Australia
Pushed 8.x-1.x to fork repo so the diff isnt 73 pages long. Back to one line.
- 🇺🇸United States mlncn Minneapolis, MN, USA
Ah so that is what the problem is. Wherever that is documented i must always get that wrong, despite having tried in the past both with manual instructions and the rebase button in GitLab; it had seemed the catch-up rebase itself was the problem. Thanks. Also thought i had fixed it in https://git.drupalcode.org/project/redirect/-/merge_requests/164.diff (in that it was one line and useable, at least).
Either way, despite the maddening fork PLUS branch setup of Drupal issues, yes straightforward re-roll (the lines above had been changed to be better self-documentation) and back to RTBC.
- 🇦🇺Australia dpi Perth, Australia
Yeah, I'm sure this workflow quirk causes a tonne of unnecessary rebases and new MR's being created
