Contrib.social

Confirm form submission dialog blocking node form submission

Open on Drupal.org →
Created on 16 February 2023, about 2 years ago

Problem/Motivation

If there are non workspace safe forms on a node edit/add form page, the dialog's JS is blocking the submission of the node form whereas it should only block the submission of the non workspace safe form. The reason is the the selectors applying the dialog on submit buttons is too unspecific and applies the dialog on every form on the page, including the node form in this case

Steps to reproduce

On vanilla Drupal

  1. Enable the following modules: wse, devel
  2. Add devel's user switch block to any region in the claro theme's block layout settings
  3. Create a workspace and switch to it
  4. Try to create a node

Expected result: The node can be created.
Actual result: The node can't be created inside the workspace because the "submit in live dialog" appears when saving the node.

Proposed resolution

Make sure the selectors in the JS of the submit dialog are specifically applying to only the forms they are supposed to.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

s_leu

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024