- Issue created by @maijs
- Status changed to Needs review
almost 2 years ago 9:58am 15 February 2023 - Status changed to RTBC
almost 2 years ago 10:15am 15 February 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
The MR makes complete sense to me and is backward compatible.
- First commit to issue fork.
- 🇧🇷Brazil renatog Campinas
Really a great job! I'd suggest just a comma in the comment as a grammatical adjustment
-
+++ b/tests/src/Kernel/WebformSubmissionPurgeApiTest.php @@ -66,9 +66,13 @@ class WebformSubmissionPurgeApiTest extends KernelTestBase { + // At this point the submissions array will be shifted by a handler.We can use comma after "At this point" something like:
At this point, the submissions array will be shifted by a handler.
-
+++ b/tests/src/Kernel/WebformSubmissionPurgeApiTest.php @@ -66,9 +66,13 @@ class WebformSubmissionPurgeApiTest extends KernelTestBase { + // At this point the submissions array will be shifted by a hook.Similar with the previous one, where we can use comma after "At this point" E.g:
At this point, the submissions array will be shifted by a hook.
-
- @renatog opened merge request.
- 🇧🇷Brazil renatog Campinas
MR with this adjustment: https://git.drupalcode.org/project/webform/-/merge_requests/302
- 🇺🇸United States jrockowitz Brooklyn, NY
Since this is API change, it has to be committed to 6.2.x
- Status changed to Fixed
over 1 year ago 11:04pm 25 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.