Webform revisions submodule causes fatal errors for some common webform operations

Open on Drupal.org →

Created on 14 February 2023, about 2 years ago

Updated 28 March 2023, about 2 years ago

Problem/Motivation

I'm kind of between major and critical for this as it can cause fatal errors when submitting webforms, but I haven't noticed this on my fresh install, only on an existing site. So it may be something particular to my configuration.

It definitely happens on a fresh install when viewing webform results, but this will only affect a small subset of users for most sites.

Steps to reproduce

Install a fresh Drupal 9 site
Ensure you have at least one webform - the default contact form should be fine
Install and enable webform and the webform_revisions submodule of this module
Add a revision to your webform
Submit your webform. You may encounter the error at this point or it may submit successfully. It doesn't seem to happen for all forms and didn't happen for me with the steps listed here - not sure what conditions are required for it to break here.
Go to the results tab for your webform
You should see a fatal error: Error: Call to undefined method Drupal\webform\Plugin\WebformElementManager::resetPluginInstances() in Drupal\webform_revisions\WebformRevisionsSubmissionStorage->getColumns() (line 132 of /app/web/modules/contrib/config_entity_revisions/modules/webform_revisions/src/WebformRevisionsSubmissionStorage.php)

Proposed resolution

This is happening because Drupal\webform_revisions\Entity\WebformRevisionsSubmission is trying to treat the webform_revision field on webform submissions as an integer ID when it is actually an entity reference field item. So when it tries to pass it as an array key it causes a fatal error. The webform_revisions module itself defines this field as an entity reference. This could probably be resolved by either switching the field to an integer or by treating the field as an entity reference when using it. The latter seems safer, I'll attach a patch for that shortly.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇨🇦Canada dylan donkersgoed London, Ontario

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @dylan donkersgoed
@dylan-donkersgoed opened merge request.
Status changed to Fixed about 2 years ago3:44pm 14 February 2023
Comment about 2 years ago →
🇨🇦Canada dylan donkersgoed London, Ontario
It seems that this issue is actually fixed in the latest dev version. I didn't realize at first because a different fatal occurs with the same steps, but a cache clear fixes it. So I'm marking this as Fixed.
Comment about 2 years ago →
🇦🇺Australia nigelcunningham Geelong
Thanks very much for the report.

I'm glad you found it was already fixed.

Regards,

Nigel
Comment about 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Status changed to Fixed about 2 years ago1:25pm 27 March 2023
Comment about 2 years ago →
🇨🇦Canada dylan donkersgoed London, Ontario
Are there any plans to tag a new release of the module with this fix?
Comment about 2 years ago →
🇦🇺Australia nigelcunningham Geelong
Yes, I'm just completing a project in which we're using config entity revisions, and making sure the small changes / fixes I've introduced as part of that are reliable and complete.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024