Entity queries must explicitly set whether the query should be access checked or not

In Drupal 10, accessCheck() method is required in entityQuery calls. Here is a patch that adds the required method to the entityQuery call.

Patch from #3 is working. Changing status to reviewed.

Just uploading a patch where I've removed the comments form my IDE.

Fixing some issues with the patch file.

I ended up patching the method in Drupal core (core/lib/Drupal/Core/Entity/Query/Sql/Query.php) to add a call to accessCheck. This seems to remove this problem. It's not a good solution since they seem to want to push the call to accessCheck out to the modules.

  /**
   * {@inheritdoc}
   */
  public function execute() {
    return $this
      ->accessCheck(TRUE)
      ->prepare()
      ->compile()
      ->addSort()
      ->finish()
      ->result();
  }

Another solution is to patch the call to execute in src/LicenseStorage.php with a call to accessCheck:

public function getExistingLicense(ProductVariationInterface $variation, $uid) {

Also there's a call in src/Cron.php:

protected function getLicensesToExpire(int $time): array {

Should be committed.

As I can see, It was already done on https://www.drupal.org/project/prevnext/issues/3289140 📌 Automated Drupal 10 compatibility fixes Fixed issue but it was committed with accessCheck = FALSE which is not correct.

Hi guys,
I'm gonna upload a new patch that should solve the problem with the accessCheck call.

Thank you for your contribution, it will get released soon.

Automatically closed - issue fixed for 2 weeks with no activity.