- Issue created by @sidharth_soman
- Status changed to Needs work
almost 2 years ago 10:12am 14 February 2023 - 🇮🇳India sidharth_soman Bangalore
Finding the following errors using php codesniffer. I am working on solving them.
C:\xampp\htdocs\backendassignment\web\modules\contrib>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig simple_responsive_table-3341519 FILE: ...xampp\htdocs\backendassignment\web\modules\contrib\simple_responsive_table-3341519\css\simple-responsive-table.css ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\simple_responsive_table-3341519\README.md ----------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------- 13 | WARNING | Line exceeds 80 characters; contains 100 characters 32 | WARNING | Line exceeds 80 characters; contains 122 characters ----------------------------------------------------------------------------------------------------- FILE: ...\xampp\htdocs\backendassignment\web\modules\contrib\simple_responsive_table-3341519\simple_responsive_table.module ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\simple_responsive_table-3341519\src\Form\SettingsForm.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- Time: 919ms; Memory: 6MB - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:21am 14 February 2023 - 🇮🇳India sidharth_soman Bangalore
I have fixed all issues. Please review this patch.
- 🇮🇳India nayana_mvr
Verified the patch #3 and tested it on Drupal version 9.5.x and Minimal Lite 8.x-1.x. The patch applied cleanly and all the coding standard issues are fixed after applying the patch. Need RTBC+1.
- Status changed to RTBC
almost 2 years ago 7:06am 15 February 2023