Undefined indexes

Created on 13 February 2023, about 2 years ago

Problem/Motivation

Undefined indexes:

Notice: Undefined index: message in commerce_manual_payment_submit_form() (line 52 of /var/www/html/*/sites/all/modules/commerce_manual_payment/commerce_manual_payment.module).
Notice: Undefined index: remote_id in commerce_manual_payment_submit_form() (line 44 of /var/www/html/*/sites/all/modules/commerce_manual_payment/commerce_manual_payment.module).

Steps to reproduce

Add a manual payment and check the logs.

Proposed resolution

The $pane_values array is using the labels instead of the keys.

  // Merge in default values.
  $pane_values += array(
    'Message' => '',
    'Remote ID' => '',
  )

;

It should be switched to:

  // Merge in default values.
  $pane_values += array(
    'message' => '',
    'remote_id' => '',
  );
🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024