Inside of hook_theme_suggestions_HOOK_alter there is this code:
if (is_numeric($index)) {
array_splice($suggestions_rev, $index, 0, $block_type_suggestions);
$suggestions = array_reverse($suggestions_rev);
}
// If block__block_content isn't present as a suggestion.
else {
$suggestions_rev = array_merge($suggestions_rev, $block_type_suggestions);
$suggestions = array_reverse($suggestions_rev);
}
Which works fine. But I was reading a recommendation to avoid using else if possible to have the code more easy to read. As we can see on this article: https://levelup.gitconnected.com/how-you-can-avoid-using-else-in-your-co...
So on this article we can use "early-return" to improve that. Example:
From:
To:
We can implement the early return and remove the unnecessary else on this case
Fixed
1.4
Code
MR created with this improvement: https://git.drupalcode.org/project/ebt_core/-/merge_requests/16