Created on 10 February 2023, about 2 years ago

Problem/Motivation

To resolve coding standard issues for the module.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs review

Version

2.1

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sidharth_soman
  • Status changed to Needs work about 2 years ago
  • 🇮🇳India sidharth_soman Bangalore

    Finding the following issues.

    C:\xampp\htdocs\backendassignment\web\modules\contrib>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig dynamictagclouds-3340816
    
    FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\css\default_tag_cloud.css
    --------------------------------------------------------------------------------------------------------------
    FOUND 8 ERRORS AFFECTING 8 LINES
    --------------------------------------------------------------------------------------------------------------
      1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
      3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
    --------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------------------------------------
    
    
    FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\css\index_tag_cloud.css
    ------------------------------------------------------------------------------------------------------------
    FOUND 22 ERRORS AFFECTING 22 LINES
    ------------------------------------------------------------------------------------------------------------
      1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
      2 | ERROR | [x] Multiple selectors should each be on a single line
      3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
      9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
     36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
    ------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------
    
    
    FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\dynamictagclouds.install
    -------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    -------------------------------------------------------------------------------------------------------------
     1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
     4 | ERROR | [x] Doc comment short description must be on the first line
    -------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------
    
    
    FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\src\Annotation\TagCloud.php
    ----------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------------------------------------------------
     1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
    ----------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------
    
    
    FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\src\Plugin\Block\TagCloudBlock.php
    -----------------------------------------------------------------------------------------------------------------------
    FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 10 LINES
    -----------------------------------------------------------------------------------------------------------------------
       1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
      23 | ERROR   | [ ] Missing member variable doc comment
      24 | ERROR   | [ ] Missing member variable doc comment
      57 | WARNING | [ ] Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
      70 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
      73 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
      83 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
      90 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
      98 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
     145 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
    -----------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -----------------------------------------------------------------------------------------------------------------------
    
    
    FILE: ...ampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\src\Plugin\TagCloud\DefaultTagCloud.php
    ------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ------------------------------------------------------------------------------------------------------------------------
     1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
     5 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
    ------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: ...\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\src\Plugin\TagCloud\IndexTagCloud.php
    ------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    ------------------------------------------------------------------------------------------------------------------------
     1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
     5 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
     8 | ERROR | [ ] Missing short description in doc comment
    ------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\src\Plugin\TagCloudBase.php
    ----------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
    ----------------------------------------------------------------------------------------------------------------
      1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
     16 | ERROR   | [x] Expected 1 blank line before function; 2 found
     22 | WARNING | [x] A comma should follow the last multiline array item. Found: )
    ----------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------
    
    
    FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\src\Plugin\TagCloudInterface.php
    ---------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------------
     1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
    ---------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------------------------------------------------
    
    
    FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\dynamictagclouds-3340816\src\Plugin\TagCloudManager.php
    -------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    -------------------------------------------------------------------------------------------------------------------
      1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
     26 | ERROR | [x] Expected 1 blank line before function; 2 found
    -------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    -------------------------------------------------------------------------------------------------------------------
    
    Time: 721ms; Memory: 6MB
    

    I will work on these.

  • 🇮🇳India sidharth_soman Bangalore

    I have fixed them all except for dependency injection.
    Please review.

  • Issue was unassigned.
  • Status changed to Needs review about 2 years ago
Production build 0.71.5 2024