Add a button to remove an embedded media item from the editor

Created on 9 February 2023, almost 2 years ago

Updated 21 July 2023, over 1 year ago

Problem/Motivation

This issue is the same as ✨ Add a button to remove an embedded media item from the editor Needs work .

In reviewing #2994702: Allow editors to alter embed-specific metadata, as well as `data-align` and `data-caption` → , the UX team had this feedback about the "remove" button that appears for each embedded media item:

...it [is] entirely too easy to accidentally stray-click the "X" icon and remove an embed. They asked for a confirmation dialog to be displayed first. Since the existing image embed button does not display an "X" (you just have to click the embedded image and press Delete on your keyboard), we agreed to remove the "X" button from this patch and add it back, with a confirmation alert box, in a follow-up.

That's this follow-up.

Proposed resolution

Reroll the core patch for the contrib module. Restore and update the relevant code from #2994702-43: Allow editors to alter embed-specific metadata, as well as `data-align` and `data-caption` → into a new patch in this issue, and add a confirmation dialog when the "remove" button is clicked. (Also, figure out if the presence of the confirmation should be configurable.)

Remaining tasks

Restore the old code, then determine what the text of the confirmation box should be, whether it should be configurable, etc. Then add tests, get UX and accessibility sign-off, and commit.

User interface changes

Media items embedded in a CKEditor instance will receive a new button which allows them to be removed from the content.

API changes

None expected.

Data model changes

None

✨ Feature request

Status

Needs work

Version

1.0

Component

Code

Created by

🇳🇱Netherlands seanB Netherlands

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @seanB
Status changed to Needs review almost 2 years ago9:41am 9 February 2023
Comment almost 2 years ago →
🇳🇱Netherlands seanB Netherlands
This probably also needs the patch in ✨ Add a button to remove an embedded media item from the editor Needs work .
Comment almost 2 years ago →
System Message
The last submitted patch, 2: 3340516-2.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.
Status changed to Needs work over 1 year ago11:57am 21 July 2023
Comment over 1 year ago →
🇳🇱Netherlands seanB Netherlands
Attached patch works for Drupal 10.1 and the core patch in #49 from ✨ Add a button to remove an embedded media item from the editor Needs work .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024