- Issue created by @mandclu
- @mandclu opened merge request.
- Status changed to Needs review
over 1 year ago 8:21am 9 February 2023 - π¨π¦Canada mandclu
A first attempt at the proposed changes is now in the merge request.
-
mandclu β
committed b3504081 on 2.2.x
Issue #3340486: Provide Site Studio components as a package
-
mandclu β
committed b3504081 on 2.2.x
- Status changed to Fixed
over 1 year ago 11:11am 9 February 2023 - π¨π¦Canada mandclu
I tested this on a fresh install of Acquia CMS and it worked as intended, including the preview thumbnails for the components.
I did get a fatal error when saving a media image with an SVG file attached, but that turned out to be a problem with focal_point, and a fix is available in π FocalPointManager::saveCropEntity(): Argument #3 must be of type int, null given Fixed .
In case anyone is searching in this issue queue for the relevant error, here it is:
TypeError: Drupal\focal_point\FocalPointManager::saveCropEntity(): Argument #3 ($width) must be of type int, null given, called in /app/web/modules/contrib/focal_point/focal_point.module on line 99 in Drupal\focal_point\FocalPointManager->saveCropEntity() (line 94 of /app/web/modules/contrib/focal_point/src/FocalPointManager.php)
Automatically closed - issue fixed for 2 weeks with no activity.