Provide Site Studio components as a package

Created on 9 February 2023, almost 2 years ago

Problem/Motivation

Configuration for SVG image components was introduced in #3228128: Provide vector-based Site Studio components but the YAML approach used has since been deprecated, and as a result the related images (e.g. for thumbnails) are not carried over.

Proposed resolution

Provide updated configuration based on the relevant documentation. The source code for Acquia CMS Site Studio is a useful implementation reference.

Feature request
Status

Fixed

Version

2.2

Component

Code

Created by

🇨🇦Canada mandclu

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mandclu
  • @mandclu opened merge request.
  • Status changed to Needs review almost 2 years ago
  • 🇨🇦Canada mandclu

    A first attempt at the proposed changes is now in the merge request.

    • mandclu committed b3504081 on 2.2.x
      Issue #3340486: Provide Site Studio components as a package
      
  • Status changed to Fixed almost 2 years ago
  • 🇨🇦Canada mandclu

    I tested this on a fresh install of Acquia CMS and it worked as intended, including the preview thumbnails for the components.

    I did get a fatal error when saving a media image with an SVG file attached, but that turned out to be a problem with focal_point, and a fix is available in 🐛 FocalPointManager::saveCropEntity(): Argument #3 must be of type int, null given Fixed .

    In case anyone is searching in this issue queue for the relevant error, here it is:
    TypeError: Drupal\focal_point\FocalPointManager::saveCropEntity(): Argument #3 ($width) must be of type int, null given, called in /app/web/modules/contrib/focal_point/focal_point.module on line 99 in Drupal\focal_point\FocalPointManager->saveCropEntity() (line 94 of /app/web/modules/contrib/focal_point/src/FocalPointManager.php)

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024