- Issue created by @gayatri chahar
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 4:15am 9 February 2023 - ๐ฎ๐ณIndia jay jangid Jaipur
Jay Jangid โ made their first commit to this issueโs fork.
- Assigned to jay jangid
- @jay-jangid opened merge request.
- Issue was unassigned.
- ๐ฎ๐ณIndia jay jangid Jaipur
Thanks @gayatri chahar for creating patch.It's working fine for me.
Created MR after patch apply.
Please review this MR. - Status changed to Needs work
about 2 years ago 8:17am 9 February 2023 - ๐ฌ๐งUnited Kingdom joachim
Thanks for the patch!
Let's call it a bug though - modules should provide a hook_help().
There's a few things that need fixing though:
-
+++ b/entity_reference_delete.module @@ -8,6 +8,23 @@ +
Stray whitespace.
-
+++ b/entity_reference_delete.module @@ -8,6 +8,23 @@ +{
Opening bracket in wrong place.
-
+++ b/entity_reference_delete.module @@ -8,6 +8,23 @@ + $output .= '<p>' . t('TThe Entity Reference Delete module allows reference fields to enforce referential integrity by deleting related entities.') . '</p>';
Typo: 'TThe'.
-
+++ b/entity_reference_delete.module @@ -8,6 +8,23 @@ + default:
I don't think we need this.
-
- Status changed to Needs review
about 2 years ago 5:15am 10 February 2023 -
joachim โ
committed 37de5fc6 on 1.0.x authored by
gayatri chahar โ
Issue #3340446 by Jay Jangid, gayatri chahar: hook_help missing in ....
-
joachim โ
committed 37de5fc6 on 1.0.x authored by
gayatri chahar โ
- Status changed to Fixed
about 2 years ago 5:28pm 10 February 2023 - ๐ฌ๐งUnited Kingdom joachim
Committed, with a few further fixes.
Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.