Fix status formatter for closed exception date

Created on 8 February 2023, over 1 year ago
Updated 17 February 2023, over 1 year ago

Problem/Motivation

Exception times don't allow blank entries

Steps to reproduce

Make an exception with blank times

Proposed resolution

Allow the times in the exception to be null like the normal hours. Having the normal hours listed then allowing for say "next" Tuesday to be closed as an exception would be ideal by having the date come and out without altering the normal hours.

✨ Feature request
Status

Fixed

Version

1.7

Component

Code - widget

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @scottriggle
  • Status changed to Fixed over 1 year ago
  • πŸ‡³πŸ‡±Netherlands johnv

    If you try the dev-version, it must be possible.

  • Works as intended.

    I may be wrong but does an exception have anything to do with the current status? If I try a normal hours day that is closed and make an exception of 9-5 open, it still says closed as the status.

    I also tried the new Seasons (excited) it also shows both sets of times and had no effect on the current status.

    My use case is we have 20 plus eating locations, all with different hours. We set normal hours, then it would be ideal if we could make an exception of next Monday they are closed and it have an effect on the open/closed status. That way every friday they don't have to rush and change 20 locations and rush on Tuesday to change them all back.

  • πŸ‡³πŸ‡±Netherlands johnv

    Nice to hear of a use case :-)

    I tested the 'currently open/closed status', since I thought it works for exceptions, too (not for seasons, yet),
    and I found that adding additional opening times works correctly, but additional closing times does not work.

    I see this fits in this ticket, when we change the title (not sure if your original problem was with the status, or the exception date itself).
    Please change the title to "Adjust Status when exception date TODAY is closed" (or a variant)

    Also,
    please share your thoughts on how to show the formatter if an exception date is next week: keep it separate, as the current situation, or incorporate it in the weekdays. But if so, when to do that? (only if eception is in current week, or when within 7 days, or ...)

  • I think it's both, it would be nice if you could blank out the times on an exception (causing it to close) like normal hours And have that days open/close status change if there is an exception. An exception can now be blanked out to closed it (fixed in the dev) but the status always stayed that of the normal hours.

    I like the separation of the exception. I tell my users those "normal" hours are like the hours etched into the glass on the front of a business and exceptions are the note you tape on the door for special days.

  • πŸ‡³πŸ‡±Netherlands johnv
    • johnv β†’ committed 035a6c8c on 8.x-1.x
      Issue #3340415: Fix status formatter for closed exception date
      
  • πŸ‡³πŸ‡±Netherlands johnv

    The fix is somewhere in above patch. Please check dev version.
    Dev version also contains Seasons (work in progress). Love to hear your feedback.

    • johnv β†’ committed 64778295 on 8.x-1.x
      Issue #3340415: Fix status formatter for closed exception date
      
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024