- Issue created by @adamps
- π¬π§United Kingdom adamps
@voleger Please can you tell me if you would accept these changes? If so I can create a MR. Thanks
- Status changed to Needs work
almost 2 years ago 7:49am 9 February 2023 - πΊπ¦Ukraine voleger Ukraine, Rivne
Yes, that is the goal of porting the module for Drupal 10 - to match the Drupal 7 functionality.
Please go ahead and create PR. I'll assist as much as possible. - @adamps opened merge request.
- π¬π§United Kingdom adamps
Great thanks. I created a MR with an initial commit. All done except:
- Change the class name - because that would make it harder to diff the changes.
- Add generic entity tokens - I never wrote that part as I didn't need it for the site I was working on. Hopefully easy to copy from the D7 file
token_formatters.tokens.inc
.
- π¬π§United Kingdom adamps
For me, #4 displays the MR as "Not currently mergeable." However the tests pass and it shows a mergeable at the top of the page, so I guess we can ignore #4.
If anyone else has time to continue from here that would be great.
-
voleger β
committed 2de5016d on 1.0.x authored by
AdamPS β
Issue #3340378 by AdamPS: Match Drupal 7
-
voleger β
committed 2de5016d on 1.0.x authored by
AdamPS β
- @voleger opened merge request.
-
voleger β
committed fcb05c85 on 1.0.x
Issue #3340378 by voleger, AdamPS: Match Drupal 7
-
voleger β
committed fcb05c85 on 1.0.x
- Status changed to Fixed
almost 2 years ago 8:50am 14 February 2023 - @adamps opened merge request.
- Status changed to Needs review
almost 2 years ago 10:59am 14 February 2023 - π¬π§United Kingdom adamps
Great thanks. I created a new MR for the file rename - please can you take a look.
I created a follow-up issue β¨ Add generic entity tokens Active
-
voleger β
committed 3c3fc6bb on 1.0.x authored by
AdamPS β
Issue #3340378 by AdamPS, voleger: Match Drupal 7
-
voleger β
committed 3c3fc6bb on 1.0.x authored by
AdamPS β
- Status changed to Fixed
almost 2 years ago 3:10pm 15 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.