Social media platforms required?

Created on 8 February 2023, about 2 years ago

Updated 19 September 2023, over 1 year ago

Problem/Motivation

I don't use Instagram, YouTube, would like to remove those icons. Removing the value for those fields does not remove the icons.

Steps to reproduce

1. Navigate to Appearance > Appearance Settings
2. Remove the value from Instagram and YouTube fields, Save
3. The Instagram and YouTube icons remain on the page, linked to my site.

Proposed resolution

Remove the social media icon for any field not filled out.

✨ Feature request

Status

Fixed

Version

1.0

Component

Miscellaneous

Created by

🇺🇸United States mrtoner

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @mrtoner
Comment almost 2 years ago →
🇧🇪Belgium jpflorent
In page.html.twig

Add a conditionnality for each social media icon:
Example:
{% if january_social_link_facebook %}

{% endif %}

Status changed to Needs review over 1 year ago

Comment over 1 year ago →

🇮🇳India chanchal tiwari

I have created a patch to fix this issue. Please review it.

Comment over 1 year ago →

tanuja_02

Review the "social-media-icons-3340129.patch" and get this error on applying:

error: web/themes/contrib/january_theme/templates/layout/page.html.twig: No such file or directory

Status changed to Needs work over 1 year ago

Comment over 1 year ago →

tanuja_02

First commit to issue fork.

@sakthi_dev opened merge request.

Status changed to Needs review over 1 year ago

Comment over 1 year ago →

🇮🇳India sakthi_dev

Please review.

Status changed to RTBC over 1 year ago

Comment over 1 year ago →

tanuja_02

Verified the MR9 on 9.5.8 and it's working fine. The social icons are not showing without filling in the fields. Added screenshots for reference and moving this to RTBC.

First commit to issue fork.

Comment over 1 year ago →

System Message

heni_deepak → committed a4d2114f on 1.0.x authored by sakthi_dev →
```
Issue#3340129: Conditional check for social media.
```

Status changed to Fixed over 1 year ago

Comment over 1 year ago →

🇮🇳India heni_deepak Jaipur, Rajasthan, India

Comment over 1 year ago →

System Message

Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024