Fix JSON:API compatibility

Open on Drupal.org →

Created on 7 February 2023, over 2 years ago

Updated 23 February 2023, over 2 years ago

Problem/Motivation

Fatal error: Declaration of Drupal\jsonapi\Normalizer\CommerceApiImposter\EnhancedResourceObjectNormalizer::normalize($object, $format = null, array $context = []) must be compatible with Drupal\jsonapi\Normalizer\ResourceObjectNormalizer::normalize($object, $format = null, array $context = []): ArrayObject|array|string|int|float|bool|null in /var/www/html/web/modules/contrib/commerce_api/src/Normalizer/CommerceApiImposter/EnhancedResourceObjectNormalizer.php on line 58

Fatal error: Declaration of Drupal\jsonapi\Normalizer\CommerceApiImposter\MetaRelationshipNormalizer::normalize($object, $format = null, array $context = []) must be compatible with Drupal\jsonapi\Normalizer\RelationshipNormalizer::normalize($object, $format = null, array $context = []): ArrayObject|array|string|int|float|bool|null in /var/www/html/web/modules/contrib/commerce_api/src/Normalizer/CommerceApiImposter/MetaRelationshipNormalizer.php on line 53

Steps to reproduce

Enable Commerce API in a Drupal (10.0.3) project with JSON:API enabled.

Proposed resolution

Make the method declarations compatible.

Remaining tasks

-
- Review MR
- Merge MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇳🇱Netherlands ricovandevin

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @ricovandevin
@ricovandevin opened merge request.
Status changed to Needs review over 2 years ago1:13pm 7 February 2023
Comment over 2 years ago →
🇳🇱Netherlands ricovandevin
Comment over 2 years ago →
🇮🇱Israel jsacksick
The problem is, the parent method signature changes are only present in D10, not D9.
Status changed to Fixed over 2 years ago9:33am 23 February 2023
Comment over 2 years ago →
🇮🇱Israel jsacksick
So, actually, it seems we can introduce the return type changes even if the parent method doesn't have it.

Realize the tests were failing because this change makes the module incompatible with PHP7. So I committed a slightly different patch that now requires PHP8 minimum, I'll update the tests now to run on PHP8.

Thank you for this.
Comment over 2 years ago →
System Message

jsacksick → committed c4f046ca on 8.x-1.x
Issue #3339944 by ricovandevin, jsacksick: Fix JSON:API compatibility...
Comment over 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024