Improve Webform categorization to support assigning multiple categories and default categories.

Approach 2: Solves the immediate requirement of supporting multiple categories while leaving the possibility for future improvements open.

This looks like the best solution because it is portable within webforms

I agree with approach 2. Portability across webforms seems like a nice advantage. Potential translation issues don't seem as important if that issue hasn't been raised before, but hopefully that is fixable should that situation arise.

The last submitted patch, 7: 3339769-7.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 9: 3339769-9.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Seems good. My suggestion if on _webform_update_webform_setting_propertiesat includes/webform.install.inc we we're using two ifs on this piece:

if (isset($properties['category'])) {
  $properties['categories'] = [];
  if (!empty($properties['category'])) {

I think we can use the opposite, instead of verifying if (isset($properties['category'])) with the code there, we can verify the opposite if (!isset($properties['category'])) and with early return there, like this:

if (!isset($properties['category'])) {
  return $properties;
}

With that we can reduce the code indentation you know? For example:

From (before)

function _webform_update_webform_setting_properties(array $properties) {
  // Issue #3339769: Improve Webform categorization to support assigning multiple categories and default categories
  if (isset($properties['category'])) {
    $properties['categories'] = [];
    if (!empty($properties['category'])) {
      $properties['categories'] = array_values(array_filter(array_merge(
        $properties['categories'],
        (array) $properties['category']
      )));
    }
    unset($properties['category']);
  }

  return $properties;
}

To: (new)

function _webform_update_webform_setting_properties(array $properties) {
  // Issue #3339769: Improve Webform categorization to support assigning multiple categories and default categories
  if (!isset($properties['category'])) {
    return $properties;
  }

  $properties['categories'] = [];
  if (!empty($properties['category'])) {
    $properties['categories'] = array_values(array_filter(array_merge(
      $properties['categories'],
      (array) $properties['category']
    )));
  }
  unset($properties['category']);


  return $properties;
}

Patch with the example of suggestion

I don't want to do an early return via _webform_update_webform_setting_properties to allow other tickets to alter a webform's properties in the future.

@see _webform_update_webform_setting_settings()

Got it, really Makes sense. Good catch

I just hid #14 in favor of #11

Automatically closed - issue fixed for 2 weeks with no activity.

In case someone finds this thread with same issue as me, the change to 'categories' instead of 'category' broke some entityQuery instances. So must change any conditions for categories from:

->condition('category', 'Category Name')

to:

->condition('categories.*', 'Category Name')

As a side note, it may be nice to add a `hasCategory()` method to the Webform class as well

Yes endless_wander, this would be nice.. ->hasCategory()

Hi,

Although I appreciate this adjustment immensely, I would have preferred to see it documented in the change records as it could potentially break existing code and therefore likely requires changes.

In the past, using $category = $webform->get('category') (assuming a webform could only have one category) will now return NULL. Updating the code to $webform->get('categories') will now return an array of categories.

(My apologies if this information is already documented somewhere and I overlooked it).