2.0.0 and 3.0.0 functional parity and fix JS selector

Created on 6 February 2023, almost 2 years ago

Problem/Motivation

The new JavaScript file queries the entire HTML document for the first instance of ".field__items" instead of only searching the placeholder contents. Also, the 2.0.x version of this module had a fallback to replace placeholder content with the random entities when the ".field__items" is not found. Lastly, setting the display style to an empty string will remove the inline "display: none" style instead of overriding any CSS stylesheets using the display property directly on the placeholder like it does now when setting "initial" on the inline style.

Steps to reproduce

Do not include a ".field__items" tag inside the placeholder and set a "display" style on the placeholder in a CSS stylesheet file.

Proposed resolution

Slightly alter the JS to be more flexible and have functional parity with the 2.0.x branch.

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States daniel korte Brooklyn, NY

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @daniel korte
Issue was unassigned.
Status changed to Needs review almost 2 years ago8:17pm 6 February 2023
Comment almost 2 years ago →
🇺🇸United States daniel korte Brooklyn, NY
Comment almost 2 years ago →
System Message

hugronaphor → committed 83da04fa on 3.0.x authored by Daniel Korte →
Issue #3339721 by Daniel Korte: 2.0.0 and 3.0.0 functional parity and...
Status changed to Fixed almost 2 years ago9:57pm 6 February 2023
Comment almost 2 years ago →
🇬🇧United Kingdom hugronaphor
Makes total sense.
Definitely skipped this when re-writting without JQuery.

Committed and available in new RC3 →

Thank you
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024