- Issue created by @arisen
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 7:50am 6 February 2023 - Status changed to RTBC
almost 2 years ago 10:58am 6 February 2023 - 🇮🇳India mrinalini9 New Delhi
Hi,
I have reviewed patch #2 (on the 3.0.x branch) with drupal version: 10.0.0, it applied cleanly and fixed all coding standards issues as mentioned above.
Checking patch redoc_field_formatter.info.yml... Checking patch src/Plugin/Field/FieldFormatter/RedocUIFormatter.php... Applied patch redoc_field_formatter.info.yml cleanly. Applied patch src/Plugin/Field/FieldFormatter/RedocUIFormatter.php cleanly.
Also, tested the Redoc UI functionality, and it's working fine.
I have followed below mentioned testing steps:
1. Install and set up the drupal 10 site.
2. Go to the modules folder and clone the Redoc Field Formatter project.
3. Switch to branch 3.0.x.
4. Execute: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .
5. Observe the coding standard errors.
6. Now, apply patch #2.
7. Again repeat step 4, you can see that the coding standards errors are fixed.
8. Now, install the module and clear all cache.
9. Then, create any content type and add a field of type as "File" in "Manage Fields". Make sure to add "json", "yml" in "Allowed file extensions" while using "File" type.
10. Now, go to the manage display tab of this content type.
11. Under File fields, select as "Redoc UI" formatter in the dropdown.
12. Then, create any content by using this content type.
13. Now, go to the page you have created now and check the Redoc UI formatter. Refer to this screenshot:Thanks & Regards,
Mrinalini - Status changed to Fixed
almost 2 years ago 11:40am 6 February 2023 - 🇮🇳India arisen Goa
Thank you Mrinalini for the review. Committed the fixes to the Drupal 10 dev branch.
Automatically closed - issue fixed for 2 weeks with no activity.