- Issue created by @renatog
- @renatog opened merge request.
- Status changed to Needs review
about 2 years ago 7:22pm 5 February 2023 - 🇧🇷Brazil renatog Campinas
MR created with this: https://git.drupalcode.org/project/mimemail/-/merge_requests/6
- Status changed to Needs work
about 2 years ago 9:35pm 5 February 2023 - 🇺🇸United States tr Cascadia
A composer.json is not required or needed unless a module contains an external dependency. The Drupal composer scaffolding automatically picks up Drupal modules listed as dependencies in the .info.yml.
It's not wrong to have a composer.json, but if we're going to add it it should be correct. In the patch above the license is wrong and the test dependencies are missing.
- 🇧🇷Brazil renatog Campinas
You're right! Running
$composer validate
is returning- License "GPL-2.0" is a deprecated SPDX license identifier, use "GPL-2.0-only" or "GPL-2.0-or-later" instead
- Status changed to Needs review
about 2 years ago 10:57pm 5 February 2023 - 🇧🇷Brazil renatog Campinas
MR updated with the fixed: https://git.drupalcode.org/project/mimemail/-/merge_requests/6
Now on
$composer validate
is returning./composer.json is valid
- 🇺🇸United States tr Cascadia
OK thanks. One more question. In the "authors" section, are there other standard "roles" that can be used? I have been the only actual "maintainer" for the past five years, and I did all the porting to Drupal 8 and Drupal 9. No one else has commit privileges. Allie Micka is the original author, but hasn't contributed to the module for more than 12 years. So I'd either like to remove the "authors" section entirely or attach different roles to the other people listed to accurately describe their participation without excluding them from credit.
- Status changed to Needs work
about 2 years ago 11:32pm 5 February 2023 - 🇧🇷Brazil renatog Campinas
In the "authors" section, are there other standard "roles" that can be used?
Yeah, good point. The key "authors" is optional, and the value is "free" so we can define and put like
"role": "Maintainer"
,"role": "Author"
,"role": "co-maintainer"
, etcSo I'd either like to remove the "authors" section entirely
I also agree with that. Specially because if the user runs$composer show drupal/mimemail
will appear the full list, and can be confused have a lot of members in the list but only one official.So since this session is optional I also agree that removing the entire "authors" section will be clear on this case
- Status changed to Needs review
about 2 years ago 11:34pm 5 February 2023 - 🇧🇷Brazil renatog Campinas
MR updated with that point that we talked at #7 / #8: https://git.drupalcode.org/project/mimemail/-/merge_requests/6
- 🇧🇷Brazil renatog Campinas
MR updated with that point that we talked at #7 / #8: https://git.drupalcode.org/project/mimemail/-/merge_requests/6
- 🇮🇳India rinku jacob 13 Kerala
Hi @RenatoG, Reviewed your Merge request . It was successfully applied, and i have noticed author section removed from composer.json according to your comment on #8. Need RTBC+1.
- Status changed to Fixed
about 2 years ago 5:23am 6 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.