- Issue created by @damienmckenna
- Status changed to Needs review
over 2 years ago 5:46pm 4 February 2023 - 🇺🇸United States damienmckenna NH, USA
This comments out the fields that need to be resolved, so only a few fields are actually migrated. When I run this migration on a site as part of a Commerce 1 migration the payments page for an order now includes the payment amount in the "total paid" value and the "order balance" is now 0.00, as it should be.
The last submitted patch, 3: commerce_migrate-n3339270-3.patch, failed testing. View results →
- 🇺🇸United States damienmckenna NH, USA
Whoops, forgot to comment out another line. Will this one work?
The last submitted patch, 5: commerce_migrate-n3339270-5.patch, failed testing. View results →
- Status changed to Needs work
over 2 years ago 2:09pm 6 February 2023 - 🇮🇱Israel jsacksick
1.x Payment transactions aren't exactly a 1:1 mapping to payment methods in Commerce 2.
The closest equivalent to transactions in 2.x are payment entities, not payment methods, so not sure how this could work?
- 🇺🇸United States damienmckenna NH, USA
If you look at the map it creates extra records from the commerce1_payment_transaction source.
- 🇺🇸United States damienmckenna NH, USA
Per a Slack conversation, it is possible that the records are only needed for certain payment methods, so logic will be needed to work out which payment records should be given a commerce_payment_method record.
- 🇺🇸United States damienmckenna NH, USA
Apparently I never learned how to spell the word "default".
- 🇺🇸United States damienmckenna NH, USA
One more time for the folks at the back.
- 🇺🇸United States damienmckenna NH, USA
I think the "type" value should be based on the available payment method types, so let's try a static_map for that. Some of these were based on the plugin definitions, some were guesses.
- 🇺🇸United States aasarava San Diego
Are you sure this migration is what's fixing the payment calculation? I applied the patches from #3295839 and #3339236, imported the payments. Initially the balance was not $0 -- but it corrected itself after flushing caches.