Contrib.social

Fix coding standards

Open on Drupal.org →
Created on 4 February 2023, almost 2 years ago
Updated 9 February 2023, almost 2 years ago

Problem/Motivation

Running a coding standards check reveals some issues:

> ./vendor/bin/phpcs -p --colors --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md ./web/modules/contrib/block_visibility_conditions
W.W.W.WE 8 / 8 (100%)



FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/modules/block_visibility_conditions_taxonomy/block_visibility_conditions_taxonomy.install
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 95 characters
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/modules/block_visibility_conditions_commerce/block_visibility_conditions_commerce.install
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 95 characters
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/modules/block_visibility_conditions_node/block_visibility_conditions_node.install
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 91 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/block_visibility_conditions.install
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 86 characters
 9 | WARNING | Line exceeds 80 characters; contains 81 characters
-------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/block_visibility_conditions/src/Plugin/Condition/NotConditionPluginBase.php
-------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------
 33 | ERROR | [x] Data types in @var tags need to be fully namespaced
 63 | ERROR | [x] Data types in @param tags need to be fully namespaced
 65 | ERROR | [x] Data types in @param tags need to be fully namespaced
 74 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------
📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇯🇵Japan ptmkenny

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @ptmkenny
  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇯🇵Japan ptmkenny

    Added an MR fixing the issues. The version should be 2.x but I can only select 2.0 in the "Version" select.

  • @matthiasm11 opened merge request.
  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇧🇪Belgium matthiasm11

    Thank you for your work. I created a merge request (I was able to select 2.x, I'm not sure what went wrong when you tried it) and merged the MR in 2.x. It will be available with the next release.

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024