- Issue created by @nicoloye
- Assigned to fmb
- 🇫🇷France fmb Perpinyà, Catalonia, EU
In the D9 version, a "release" can be either an l10n_server_release or and l10n_packager_release entity. In the D7 version, l10n_packager_release_set_branch applies to what would be an l10n_server_release entity, whereas l10n_packager_release_check would be l10n_packager_release. What is the point of the first call in this context anyway? How could this be solved, according to you?
- Status changed to Needs review
over 2 years ago 3:49pm 3 April 2023 - 🇫🇷France fmb Perpinyà, Catalonia, EU
@sanduhrs declared some arguments (force and all) which do not exist in the D7 version. What are we supposed to do?
I am not exactly sure what other two commands (create/queue) are for BTW.
- 🇫🇷France fmb Perpinyà, Catalonia, EU
Apparently sanduhrs wanted to use the queue API in l10n_packager_cron(). I commented the code in the meantime until we make a decision on this point.
- Status changed to Postponed
about 2 years ago 10:04am 7 June 2023 - 🇫🇷France fmb Perpinyà, Catalonia, EU
Postponing until migrations are a thing, so we can test on real data.
- Status changed to Needs work
8 months ago 5:44pm 8 November 2024 - 🇨🇭Switzerland colorfield Lausanne
Discussed with @fmb during Barcamp Perpignan
Keep 1 to 1 port for now
Remove dead code:
- new options: force, all
- new (not implemented) drush commands: create, queueAs queue is not implemented yet, prevent to introduce extra complexity (release, unprocessed items)
D7 was not using it, so it should work https://git.drupalcode.org/project/l10n_server/-/blob/7.x-1.x/l10n_packa...Make sure that it works like this
- Check database query with D7 one
- Set the source of truth
- Create testWorking on it
-
colorfield →
committed 6de0ede4 on 3.0.x
Issue #3338985 by colorfield: remove dead code, use attributes
-
colorfield →
committed 6de0ede4 on 3.0.x