- Issue created by @meyerrob
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for pointing out this problem. However, I fear your fix is not the correct one, as it wouldn’t allow passing
NULLas the first parameter, which is the real reason that default value is there. (?SearchApiServerisn’t allowed in PHP 5.2.) Please see/test/review the attached patch with the, hopefully, correct fix. - 🇩🇪Germany meyerrob
You are totally right, the default value for the first parameter must default to null, therefore the solution to make the second parameter optional as well seems to be a solution. Maybe we should be sure that the second parameter can´t be empty at all.
-
drunken monkey →
committed f15717e9 on 7.x-1.x
Issue #3338975 by drunken monkey, meyerrob: Fixed deprecation warning in...
-
drunken monkey →
committed f15717e9 on 7.x-1.x
- Status changed to Fixed
almost 2 years ago 5:15pm 18 February 2023 - 🇦🇹Austria drunken monkey Vienna, Austria
Maybe we should be sure that the second parameter can´t be empty at all.
It seems to have worked so far. Also, as it’s passed by reference, even passing
NULLexplicitly should be OK there. (But I don’t think that will ever happen.)
As you otherwise seem happy with the patch: committed.
Thanks again! Automatically closed - issue fixed for 2 weeks with no activity.