Add build test to test cweagans/composer-patches end-to-end

Open on Drupal.org →

Created on 2 February 2023, almost 2 years ago

Updated 22 March 2023, over 1 year ago

Problem/Motivation

Quoting #3252299-27: Reliably support cweagans/composer-patches in Package Manager & Automatic Updates: validate stage → :

doing a build test for composer-patches is something that would be good to have, but it's post-MVP

… to test:

a core patch continues to be applied after updating core
a core patch failing to apply provides a helpful UX
a core patch failing to apply causes cron security updates to not get executed
and perhaps more?

This is postponed on 📌 Add functional test that proves there is reasonable UX whenever a stage event subscriber has an exception Fixed .

Steps to reproduce

N/A

Proposed resolution

TBD

Remaining tasks

User interface changes

TBD

API changes

None.

Data model changes

None.

📌 Task

Status

Closed: won't fix

Version

3.0

Component

Code

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

core-post-mvp

Sign in to follow issues

Comments & Activities

Issue created by @wim leers
@wim-leers opened merge request.
Comment almost 2 years ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Making sure @kunal.sachdev's pioneering work on this is not lost!

Cherry-picked the relevant commits from 📌 Reliably support cweagans/composer-patches in Package Manager & Automatic Updates: validate stage Fixed 's MR. 👍
Comment almost 2 years ago →
🇮🇳India kunal.sachdev
Wim Leers → credited kunal.sachdev → .
Comment almost 2 years ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment almost 2 years ago →
🇺🇸United States tedbow Ithaca, NY, USA
Status changed to Active almost 2 years ago10:27am 15 February 2023
Comment almost 2 years ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Reliably support cweagans/composer-patches in Package Manager & Automatic Updates: validate stage Fixed landed.
Comment almost 2 years ago →
🇮🇳India omkar.podey
omkar.podey → made their first commit to this issue’s fork.
Assigned to wim leers
Comment almost 2 years ago →
🇮🇳India omkar.podey
It seems impossible to run composer config --no-plugins allow-plugins.cweagans/composer-patches true early enough.
Issue was unassigned.
Status changed to Closed: won't fix over 1 year ago9:55am 22 March 2023
Comment over 1 year ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
As described at #3334914: Testing is broken because simplesamlphp/composer-module-installer contains a Composer plugin which is blocked → , this is not supported by/not allowed by DrupalCI.

We could switch to GitLab CI, but that's pointless, because we aim to add this module to Drupal core. And Drupal core won't be switching to GitLab CI for many months, possibly years.

So … we have only one choice: give up 🥲

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024