- Issue created by @irsar
- Status changed to Postponed: needs info
almost 2 years ago 10:56pm 5 February 2023 - πΊπΈUnited States smustgrave
Just fyi ckeditor5 plugins for this module are still experimental.
Only plugins I got working are overrides, table properties, and those I converted to content embed.
Did a fresh install and enabled this module and the editor works fine for me.
Moved some buttons around and could not trigger the errorWhat additional steps did you take?
I tried doing a fresh install and enabled the uswds_ckeditor_integration:^2.0@alpha version and when I went back to edit the text format its throwing the error "Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The CKEditor 5 "uswds_ckeditor_integration_ckeditor5_overrides" provides a plugin class: "\Drupal\uswds_ckeditor_integration\Plugin\CKEditor5Plugin\UswdsOverrideDefaults", but it does not exist. in Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition->validateDrupalAspects() (line 174 of /app/web/core/modules/ckeditor5/src/Plugin/CKEditor5PluginDefinition.php)."
Not sure if you are tried enabling the overrides in the cke4, because its working in CKE4 and not in CKE5. In CKE5 I am not even able to edit the text format after installing the ckintegration 2.0@alpha version. And when I try to lock to a lower version, I am not seeing the USWDS overrides or the accordion, alert or any other style buttons
- πΊπΈUnited States smustgrave
The ckeditor4 and ckeditor5 plugin are completely separate.
I have not gotten to a separate accordion or grid plugin for ckeditor5 yet.
Currently ckeditor5 has
Overrides for specific tags
Table attribute overrides
Ckeditor embedded content forms
- Accordion
- Alert
- Summary box
- process listBut just tested again on drupal10 with ckeditor5 and the existing functionality is working and not throwing errors for me.
We are not able to figure out what's throwing that error. Could it be Drupal 9.5.3?
We are using Drupal 9.5.3 and right after installing the UWDS integration module, its not letting us edit the USWDS editor and throwing the error.
I even tried with a fresh drupal 10 and still its throwing the same error. I just installed "ckeditor5_embedded_content" and "uswds_ckeditor_integration" modules and enabled both the modules. Then when I try to configure the USWDS CK5 text editor and got the website encountered an error message. So when I check the logs its the same error as I mentioned above. Attaching the screenshot of the same.
- πΊπΈUnited States smustgrave
Can you try the dev branch? Canβt think why but maybe something got left out. Not in front of a computer to test.
Hoping to find time this week to lease redo the accordion button.
Grid will take time
- πΊπΈUnited States smustgrave
I randomly got it access a webform config page. But on one environment so don't know the issue yet.
- Status changed to Active
over 1 year ago 11:53pm 22 February 2023 - @smustgrave opened merge request.
- Status changed to Needs review
over 1 year ago 12:10am 23 February 2023 - πΊπΈUnited States smustgrave
Can you test this out?
Man I hate ckeditor5
YAY, its working! After making these changes, I am able to enable the module without the error I had before. But I am still not able to open the embed content popup. When I check the error message, there is an AJAX error related PHP deprecation of the strlen in the embed content module.
-
smustgrave β
committed c08f6c49 on 2.0.x
Issue #3338324: CKE5 not working after enabling the cke integration...
-
smustgrave β
committed c08f6c49 on 2.0.x
- Status changed to Fixed
over 1 year ago 4:30pm 23 February 2023 - πΊπΈUnited States smustgrave
Would open a ticket there. Embedded works fine for me though.
- πΊπΈUnited States mandolinrick
I also experienced this problem on upgrading to 2.0.0-alpha2. I switched to dev and it is now working. Will be testing out the rest of the functionality and will report any issues.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 11:36pm 19 May 2023 - πΊπΈUnited States euk
I am still having this issue. Fresh install, and I am not able to manage any of the CKEditor 5 formats.
However, removing
uswds_ckeditor_integration_ckeditor5_overrides
from the CKEditor 5 plugins YML solves the issue. What can it be?My setup:
- Drupal 10.0.9,
- PHP 8.1.8,
- a number of contrib modules installed.