Bootstrap 5: progress label may be a field

Created on 1 February 2023, almost 2 years ago

Updated 8 February 2023, almost 2 years ago

Problem/Motivation

Progress label is currently a setting:

 settings:
    label:
      type: "textfield"
      label: "Label"
      description: "Text shown inside the progress bar."
      preview: "Label"
      allow_token: true

Source: https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/templ...

However, the div element allows markup as content, and it looks good when the markup doesn't have margin (for ex: em, strong, a...)

So, it may also be a field. Fields (slots) are more versatile than settings (props), so such a change is a relevant.

Proposed resolution

  fields:
    label:
      type: "text"
      label: "Label"
      description: "Text shown inside the progress bar."
      preview: "Label"

As already done fro BS4: https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/4.0.x/templ...

API changes

Careful, it is breaking change. It is OK because the theme is still in alpha, but some projects may be already using it.

🐛 Bug report

Status

Fixed

Version

5.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @pdureau
First commit to issue fork.
@grimreaper opened merge request.
Comment almost 2 years ago →
System Message

Grimreaper → committed e19c7ff2 on 5.0.x
Issue #3338285 by Grimreaper, pdureau: Bootstrap 5: progress label may...
Issue was unassigned.
Status changed to Fixed almost 2 years ago12:57pm 8 February 2023
Comment almost 2 years ago →
🇫🇷France Grimreaper France 🇫🇷
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024