Drupal Coding Standards Issues | phpcs

Created on 1 February 2023, almost 2 years ago

Updated 21 February 2023, over 1 year ago

Problem/Motivation

Getting following error/warnings.

FILE: ...odules\gdpr\modules\anonymizer\src\Anonymizer\AnonymizerBase.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
15 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...les\gdpr\modules\anonymizer\src\Anonymizer\AnonymizerFactory.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...s\gdpr\modules\anonymizer\src\Anonymizer\AnonymizerInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...dpr\modules\anonymizer\src\Plugin\Anonymizer\ClearAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
18 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...dpr\modules\anonymizer\src\Plugin\Anonymizer\EmailAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
18 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...\modules\anonymizer\src\Plugin\Anonymizer\LongTextAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
18 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...pr\modules\anonymizer\src\Plugin\Anonymizer\NumberAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
20 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...\modules\anonymizer\src\Plugin\Anonymizer\PasswordAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
21 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...odules\anonymizer\src\Plugin\Anonymizer\RandomTextAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
20 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...gdpr\modules\anonymizer\src\Plugin\Anonymizer\TextAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
19 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...\gdpr\modules\anonymizer\src\Plugin\Anonymizer\UriAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
18 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...\modules\anonymizer\src\Plugin\Anonymizer\UsernameAnonymizer.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
18 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...pal\modules\gdpr\modules\anonymizer\src\Service\FakerService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...es\gdpr\modules\anonymizer\src\Service\FakerServiceInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...ent\src\ConsentUserResolver\ConsentUserResolverPluginManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
16 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...ent\src\ConsentUserResolver\GdprConsentUserResolverInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...dules\gdpr_dump\src\Exception\GdprDumpAnonymizationException.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...\drupal\modules\gdpr\modules\gdpr_dump\src\Form\SettingsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
22 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...dules\gdpr\modules\gdpr_dump\src\Service\GdprDatabaseManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
13 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...rupal\modules\gdpr\modules\gdpr_dump\src\Service\GdprSqlDump.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
23 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...bc\drupal\modules\gdpr\modules\gdpr_dump\src\Sql\GdprSqlBase.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
17 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...c\drupal\modules\gdpr\modules\gdpr_dump\src\Sql\GdprSqlMysql.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
22 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...c\drupal\modules\gdpr\modules\gdpr_dump\src\Sql\GdprSqlPgsql.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...\drupal\modules\gdpr\modules\gdpr_dump\src\Sql\GdprSqlSqlite.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...ocs\abc\drupal\modules\gdpr\modules\gdpr_tasks\gdpr_tasks.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
67 | ERROR | All functions defined in a module file must be prefixed
| | with the module's name, found
| | "gdpr_fields_entity_type_alter" but expected
| | "gdpr_tasks_gdpr_fields_entity_type_alter"
----------------------------------------------------------------------

FILE: ...al\modules\gdpr\modules\gdpr_tasks\src\Form\TaskSettingsForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...drupal\modules\gdpr\modules\gdpr_tasks\src\Form\TaskTypeForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
10 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...odules\gdpr_tasks\src\Traversal\RightToAccessEntityTraversal.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
43 | ERROR | The array declaration extends to column 106 (the limit
| | is 80). The array content should be split up over
| | multiple lines
----------------------------------------------------------------------

FILE: ...htdocs\abc\drupal\modules\gdpr\src\Controller\UserController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
15 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

FILE: ...mpp\htdocs\abc\drupal\modules\gdpr\src\Form\ContentLinksForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
25 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/gdpr/

Proposed resolution

Above error/warnings need to be fixed.

🐛 Bug report

Status

Closed: duplicate

Version

3.0

Component

Code

Created by

🇮🇳India Charchil Khandelwal

Live updates comments and jobs are added and updated live.

ACMS2023

Comments & Activities

Issue created by @Charchil Khandelwal
@charchil-khandelwal opened merge request.
Issue was unassigned.
Status changed to Needs review almost 2 years ago11:27am 1 February 2023
Comment almost 2 years ago →
🇮🇳India Charchil Khandelwal
Created MR for this issue.
Please review.
Status changed to Closed: duplicate over 1 year ago7:19am 21 February 2023
Comment over 1 year ago →
🇮🇳India rajeshreeputra Pune
Hi @Charchil Khandelwal, this seems to be an dup of 📌 Coding standards Issue fixes Fixed , could you please review the other issue and make changes if any missing, and this can be closed.
Comment over 1 year ago →
🇮🇳India rajeshreeputra Pune
closing this as duplicate

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024