- Issue created by @m0d
- @m0d opened merge request.
- @m0d opened merge request.
- 🇬🇧United Kingdom m0d
- Status changed to Needs review
almost 2 years ago 10:11pm 1 February 2023 - 🇦🇹Austria fago Vienna
thanks, I added a couple of remarks to the PR.
As clarified for user-forms over at https://www.drupal.org/project/lupus_ce_renderer/issues/3338361 ✨ Adding support to User login and User password forms Closed: duplicate , we should keep lupus_ce_renderer focussed on providing the CE-renderering code & API, but avoid adding lots of specific glue code to it. Thus moving it over.I'm wondering how you control which blocks you want to have on the frontend, do you simply go with blocks configured for the default theme? This might be little confusing in the UI, but I guess makes more sense than hard-coding any other theme (like lupus_stark).
Moreover, I think this is not a feature everyone needs, e.g. we did not have a need for this yet. So I think it makes sense to have it in an optional lupus_decoupled_block sub-module. We should be able to add the output easily in the lupus_ce_renderer hook to alter the data output. Would that work for you?
- Status changed to Needs work
almost 2 years ago 10:48am 2 February 2023 - @m0d opened merge request.
- Status changed to Needs review
almost 2 years ago 12:40am 3 February 2023 - 🇬🇧United Kingdom m0d
Thanks for all the feedback! I'm getting the blocks via https://api.drupal.org/api/drupal/core%21modules%21block%21src%21BlockRe... which gets the blocks for the default theme, but we can do something else if necessary.
I recreated my PR for lupus_decoupled as a submodule, and creating the custom_element from the render array for every block :)
- Status changed to Needs work
almost 2 years ago 1:33pm 6 February 2023 - 🇦🇹Austria fago Vienna
Great thank you, this seems promising! I added some feedback, mostly small remarks, but also a question about dynamic page cache. Please check.
- Status changed to Needs review
almost 2 years ago 5:25pm 8 February 2023 - Status changed to Needs work
almost 2 years ago 9:54am 10 February 2023 - 🇦🇹Austria fago Vienna
Thank you! This looks pretty good, just found two small issues. Could you resolve those?
Else this seems ready to to me then! The Frontend PR is also merged. - Status changed to Needs review
almost 2 years ago 10:44am 10 February 2023 - Status changed to Fixed
almost 2 years ago 12:22pm 10 February 2023 - 🇦🇹Austria fago Vienna
looks all good now. I tested it and seems to work fine. Thank you, merged!
Automatically closed - issue fixed for 2 weeks with no activity.