- Issue created by @m0d
- @m0d opened merge request.
- Status changed to Needs review
over 1 year ago 10:12pm 1 February 2023 - π¦πΉAustria fago Vienna
thank you for the contribution. This seems promising!
As I understand, with that the forms are just working and after submission they are redirecting, so there is no special rendering required to make them work? That's a great!
Here a few remarks / thoughts:
* does this work fine with validation errors etc.?
* I think we should keep lupus_ce_renderer focussed on providing the CE-renderering code & API, but avoid adding lots of specific glue code to it. That is better situated in lupus_decoupled project and one of it's modules. I'd suggest to move the issue & code over.
* that said there is issue π Add support for forms Needs review for forms support there. I think it would make sense to add this to lupus_decoupled_forms sub-module there
* the forms-module there provides a re-usable forms-controller, could we just use that, or provide some sort of re-usable controller for drupal-forms resulting in a redirect that we can just use? https://git.drupalcode.org/issue/lupus_decoupled-3336148/-/blob/05d0f925...
* Lastly, I'd love to add some simple test-coverage there, ideally including the frontend, but for that the testing setup needs to prepared. Would be a good follow-up.https://git.drupalcode.org/issue/lupus_decoupled-3336148/-/blob/05d0f925...
- Status changed to Needs work
over 1 year ago 10:19am 2 February 2023 - π¬π§United Kingdom m0d
Thanks for the feedback! I've applied your feedback and adapted my changes to be a submodule for lupus_decoupled: https://www.drupal.org/project/lupus_decoupled/issues/3336148#comment-14... π Add support for forms Needs review
Should we then close this issue and move the discussion there?
- Status changed to Needs review
over 1 year ago 9:14am 6 February 2023 - Status changed to Closed: duplicate
over 1 year ago 9:54am 23 February 2023 - π¦πΉAustria fago Vienna
yes, let's do that. so closing this in favour of https://www.drupal.org/project/lupus_decoupled/issues/3336148#comment-14... π Add support for forms Needs review