Drupal Coding Standards Issues | phpcs

$ phpcs --standard=Drupal jslog FILE: C:\Users\Admin\Desktop\task\jslog\js\jslog.js -------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 4 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but | | found "false" 25 | ERROR | [x] Space before opening parenthesis of function call prohibited 49 | ERROR | [x] Expected 1 space before "?"; 0 found 49 | ERROR | [x] Expected 1 space after "?"; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\jslog\src\Controller\LogController.php -------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 45 | ERROR | [x] Expected "string" but found "string." for function return | | type 45 | ERROR | [ ] Description for the @return value is missing 69 | WARNING | [ ] Only string literals should be passed to t() where possible 85 | ERROR | [x] Expected "array" but found "array." for function return | | type 85 | ERROR | [ ] Description for the @return value is missing -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\jslog\src\Form\JsLogSettingsForm.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 59 | WARNING | [ ] Avoid backslash escaping in translatable strings when | | possible, use "" quotes instead 71 | ERROR | [x] Expected 1 blank line after function; 2 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 473ms; Memory: 8MB

Comments & Activities

Issue created by @jay jangid
@jay-jangid opened merge request.
Issue was unassigned.
Status changed to Needs review about 2 years ago11:43am 31 January 2023
Comment about 2 years ago →
🇮🇳India jay jangid Jaipur
Created MR , please review.

Thank you.
Assigned to Sonal Gyanani
Comment about 2 years ago →
🇮🇳India Sonal Gyanani
Issue was unassigned.
Status changed to RTBC about 2 years ago1:10pm 31 January 2023
Comment about 2 years ago →
🇮🇳India Sonal Gyanani
Thanks @Jay Jangid, MR looks good to me.
So moving it to RTBC
Status changed to Needs work about 2 years ago7:59pm 31 January 2023
Comment about 2 years ago →
🇧🇪Belgium martijn.cuppens
I don't think those coding standars of the js files are correct, for example false</false> is always in lowercase in other core javascript files. I also doubt spaces are required around optional chaining question marks. You also can't just replace <code>lot\'s by lot"s in the translation string.
First commit to issue fork.
@kkalashnikov opened merge request.
Status changed to Needs review about 2 years ago1:04pm 14 February 2023
Comment about 2 years ago →
🇮🇳India kkalashnikov Ghaziabad, India

Drupal Coding Standards Issues | phpcs

Problem/Motivation

Proposed resolution

Comments & Activities