Optional parameter $plugin_id declared before required parameter $plugin_definition

I guess it should be:

public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
  $plugin_id = $plugin_id ?? 'smsc';
...
}

In method

\Drupal\Core\Plugin\ContainerFactoryPluginInterface::create()

$plugin_id stay before $plugin_definition, so its inheritors should keep this order.

I tested #2 and it works.

super_romeo → closed merge request !3