Contrib.social

Fix empty/missing box shadow configs for the Bootstrap Styles

Open on Drupal.org →
Created on 29 January 2023, almost 2 years ago
Updated 9 March 2023, over 1 year ago

Problem/Motivation

After updating to Bootstrap Styles 1.1.0 →
box_shadow: "bs-shadow-sm|Small\r\nbs-shadow|Regular\r\nbs-shadow-lg|Large"
But #3188559: Plugin: Shadow → was committed around 1 year ago without a hook update!
https://git.drupalcode.org/project/bootstrap_styles/-/commit/35c0c005797...

Bootstrap Styles 1.1.0 → was release 14 Jan 2023
But the #3188559: Plugin: Shadow → was not listed in the release notes

Having the following issue when editing or saving old sections.

Proposed resolution

  • Use the default Bootstrap 4/5 Shadows classes
  • Add box_shadow: "shadow-sm|Small\r\nshadow|Regular\r\nshadow-lg|Large" to the default Varbase Layout Builder
  • Have a hook update to add the default value for old websites

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.12 → , varbase_layout_builder-10.0.27 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:

Editing a block with a shadow

Blocks with shadows after saving the layout

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3337351 → : Fixed empty/missing box shadow configs for the Bootstrap Styles
🐛 Bug report
Status

Fixed

Version

10.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024