Fix regressions in SlackRulesSendMessage

Created on 29 January 2023, almost 2 years ago

Updated 30 January 2023, almost 2 years ago

These problems were all fixed and committed in the 8.x-1.x branch anywhere between 2.5 and 4 years ago. For example, in #3170946: Update Rules integration for context_definitions → . But these bugs have resurfaced once again in the 2.0.x branch.

This is one of the reasons why I concluded that the 2.0.x branch was forked off the D7 branch a long time ago - all the D8 and D9 specific changes are missing, and there are still a lot of D7 drupalisms in the 2.0.x branch that should have disappeared long ago.

Note, this patch will not make this RulesAction plugin fully functional, because of other regressions in this module, but at least this will incorporate some old fixes into the 2.0.x branch so we can start to move forward on this.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States tr Cascadia

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @tr
Status changed to Needs review almost 2 years ago5:29am 29 January 2023
Comment almost 2 years ago →
🇺🇸United States tr Cascadia
First commit to issue fork.
@smustgrave opened merge request.
Comment almost 2 years ago →
System Message

smustgrave → committed da8227a1 on 2.0.x
Issue #3337322: Fix regressions in SlackRulesSendMessage
Status changed to Fixed almost 2 years ago3:32pm 30 January 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Thanks!
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024