Make all model exportable

Very useful supplement.

Merged and back ported. Thanks @danielspeicher for reviewing this.

1.1.x is currently a bugfix branch, where 1.2.x exists for new features. This issue is not a bugfix, and the last commit changes existing API and thus breaks compatibility, in this case specifically with eca_cm.

The missing export for some models is a big one and as 1.2 is most likely a few months away, it seems worth bringing this into 1.1 too.

It's been built in a way where it won't break compatibility. Even if you don't change eca_cm, it will still be perfectly valid - just that the export feature won't be available, which is no difference from what we have now. However, with ✨ Enable general model export in latest ECA version Fixed this would be resolved too then.

I'm getting the following error when trying to export a model via UI:

The website encountered an unexpected error. Please try again later.

Error: Call to undefined method Drupal\eca\Entity\Eca::isExportable() in Drupal\eca_ui\Controller\EcaController->export() (line 185 of modules/contrib/eca/modules/ui/src/Controller/EcaController.php).
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 681)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

It's been built in a way where it won't break compatibility. Even if you don't change eca_cm, it will still be perfectly valid - just that the export feature won't be available, which is no difference from what we have now.

Not sure about this. The export link now shows up for core models, but the modeller won't do anything (I guess).

I'm getting the following error when trying to export a model via UI:

I missed one change during the back port. Now fixed.

... but the modeller won't do anything

Yes, that's how the export function was built originally because we didn't have any access control on the route, only that display control by the modeller. Do you think we should add a message here?

Thanks for fixing this.

Do you think we should add a message here?

Guess there's no need for it. The Core modeller should now be able to automatically support the export.

Automatically closed - issue fixed for 2 weeks with no activity.