Constant 'STORAGE' not found in InPageExperienceSettingsInterface

Created on 27 January 2023, about 2 years ago

Problem/Motivation

I have noticed that constant 'STORAGE' does not exit in InPageExperienceSettingsInterface

QA steps

  • enable brightcove_gallery
  • visit /admin/structure/brightcove_in_page_experience/settings
  • udpate and save settings
🐛 Bug report
Status

Needs review

Version

3.1

Component

Code

Created by

🇵🇱Poland alorenc Wolsztyn, 🇵🇱

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @alorenc
  • @alorenc opened merge request.
  • Status changed to Needs review about 2 years ago
  • 🇵🇱Poland alorenc Wolsztyn, 🇵🇱
  • 🇵🇱Poland alorenc Wolsztyn, 🇵🇱

    STORAGE and SUB_SETTINGS in not defined in InPageExperienceSettingsInterface but only in InPageExperienceSettings.

    The second option was to move these variables to interface but i will leave decision to the author of the module.

  • 🇵🇱Poland alorenc Wolsztyn, 🇵🇱

    class Drupal\brightcove_gallery\Form\Settings does not use $this->config so the method getEditableConfigNames was never called.
    In this case I think we should not use ConfigFormBase as it requires to implement getEditableConfigNames, only FormBase.

  • 🇵🇱Poland alorenc Wolsztyn, 🇵🇱
  • Issue was unassigned.
  • 🇵🇱Poland alorenc Wolsztyn, 🇵🇱
  • First commit to issue fork.
Production build 0.71.5 2024