Fatal due to mismatch of normalizer/denormalizer class function signatures

Open on Drupal.org →

Created on 27 January 2023, almost 2 years ago

Updated 29 January 2023, almost 2 years ago

After updating a site from Drupal 9 to 10 with php 8.1, there are these fatal errors:

PHP Fatal error: Declaration of Drupal\smart_date\Normalizer\SmartDateNormalizer::denormalize($data, $class, $format = null, array $context = []) must be compatible with Drupal\serialization\Normalizer\TimestampNormalizer::denormalize($data, $class, $format = null, array $context = []): mixed in /app/web/modules/contrib/smart_date/src/Normalizer/SmartDateNormalizer.php on line 23

and

PHP Fatal error: Declaration of Drupal\smart_date\Normalizer\SmartDateItemNormalizer::normalize($object, $format = null, array $context = []) must be compatible with Drupal\serialization\Normalizer\TimestampItemNormalizer::normalize($object, $format = null, array $context = []): ArrayObject|array|string|int|float|bool|null in /app/web/modules/contrib/smart_date/src/Normalizer/SmartDateItemNormalizer.php on line 28

SmartDateNormalizer has
public function denormalize($data, $class, $format = NULL, array $context = [])

compared to TimestampNormalizer with
public function denormalize($data, $class, $format = NULL, array $context = []): mixed

and SmartDateItemNormalizer has
public function normalize($object, $format = NULL, array $context = [])

compared to TimestampItemNormalizer with
public function normalize($object, $format = NULL, array $context = []): array|string|int|float|bool|\ArrayObject|NULL

Patch to follow that adds the return types and prevents this fatal error.

🐛 Bug report

Status

Fixed

Version

3.7

Component

Code

Created by

🇺🇸United States ransomweaver

Live updates comments and jobs are added and updated live.

ContributionWeekend2023

Sign in to follow issues

Comments & Activities

Issue created by @ransomweaver
Comment almost 2 years ago →
🇺🇸United States ransomweaver
Here is the patch
Comment almost 2 years ago →
🇺🇸United States ransomweaver
Could be that this breaks a site running smart_date on drupal 8/9. Dunno what to do about that if that's the case.
Comment almost 2 years ago →
System Message

mandclu → committed 543d6307 on 3.7.x
Issue #3336779 by ransomweaver: Fatal due to mismatch of normalizer/...
Status changed to Fixed almost 2 years ago1:21pm 29 January 2023
Comment almost 2 years ago →
🇨🇦Canada mandclu
Since the current branch is not yet stable, and this is a major bug, merging this in. It seems like it would be most likely to create an issue for D9 sites running PHP 7.4. If that turns out to be the case, we can create a composer dependency to reflect the need for PHP 8.0, as noted in #3232080: [Symfony 6] Add "mixed" type hint to all Normalizer classes that implement the method ::denormalize() → . In fact, I'll go ahead and create a separate issue for that.
Comment almost 2 years ago →
🇨🇦Canada mandclu
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024